Skip to content

MQE 1692: Improve makeScreenshot Action to Add Screenshot to Allure Report #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 9, 2019
Merged

MQE 1692: Improve makeScreenshot Action to Add Screenshot to Allure Report #443

merged 4 commits into from
Sep 9, 2019

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Sep 5, 2019

Description

This pull request adds the screenshot to the allure report when the makeScreenshot action is used.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@tomreece
Copy link
Contributor Author

tomreece commented Sep 5, 2019

Build: https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/23533/

In the build above you can search for "MAGETWO-71572" to find the AdminLoginTest which I modified to make use of makeScreenshot.

@coveralls
Copy link

coveralls commented Sep 5, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 51.974% when pulling 4ae6a3a on MQE-1692 into a915bd1 on develop.

KevinBKozan
KevinBKozan approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, changes work great!

@tomreece tomreece merged commit 3e0d666 into develop Sep 9, 2019
@tomreece tomreece deleted the MQE-1692 branch December 11, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomreece @coveralls @KevinBKozan